Skip to content

Use auth v2 in subscription activation flow #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2025
Merged

Use auth v2 in subscription activation flow #6366

merged 5 commits into from
Jul 11, 2025

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Jul 9, 2025 •
edited by cmonfortep
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1205648422731273/task/1210723642420067?focus=true

Description

Steps to test this PR

  • Build with staging patch from https://app.asana.com/1/137249556945/project/1209991789468715/task/1210448620621729?focus=true
  • Go to settings -> I have a subscription
  • Click "Add via Email"
  • Verify that the app made request to api/auth/v2/.well-known/jwks.json
  • Proceed with resotoring the subscription until the success screen is shown
  • Verify that there were no requests to api/auth/access-token
  • Verify that there were no more requests to api/auth/v2/.well-known/jwks.json
  • Verify that the app settings show subscription in active state, VPN can be enabled, etc.

No UI changes

@lmac012 Graphite App
Copy link
Contributor Author

lmac012 commented Jul 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 requested a review from cmonfortep July 9, 2025 22:02
@lmac012 lmac012 force-pushed the feature/lukasz/auth-v2-subscription-activation branch 2 times, most recently from 91e4614 to b8e965f Compare July 9, 2025 22:24
@lmac012 lmac012 marked this pull request as ready for review July 10, 2025 07:33
cmonfortep
cmonfortep approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left some comments to ensure we have good signals and the proper try-catch, but other than that, lgtm and testing went well.

@lmac012 lmac012 force-pushed the feature/lukasz/auth-v2-subscription-activation branch from b8e965f to 7d938b8 Compare July 10, 2025 23:14
@lmac012 lmac012 merged commit 0b9c140 into develop Jul 11, 2025
7 checks passed
@lmac012 lmac012 deleted the feature/lukasz/auth-v2-subscription-activation branch July 11, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep cmonfortep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmac012 @cmonfortep